fix(date-picker): invoke markForCheck() on overlay open/close to prevent NG0100 in zoneless apps - 21.2.x#17307
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an ExpressionChangedAfterItHasBeenCheckedError (NG0100) occurring when toggling the IgxDatePicker calendar overlay in zoneless Angular apps by ensuring change detection is scheduled after _collapsed is updated during overlay open/close lifecycle callbacks.
Changes:
- Invoke
ChangeDetectorRef.markForCheck()after_collapsedis updated in overlayopeningandclosedhandlers. - Update unit-test mocks to include
markForCheckon theChangeDetectorRefspy. - Add a dedicated zoneless unit test reproducing issue #17305 and asserting no NG0100 is thrown on close.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
projects/igniteui-angular/date-picker/src/date-picker/date-picker.component.ts |
Schedules CD after overlay open/close state changes to prevent NG0100 in zoneless scenarios. |
projects/igniteui-angular/date-picker/src/date-picker/date-picker.component.spec.ts |
Adds a zoneless regression test and updates the CDR spy to support markForCheck(). |
MonikaKirkova
approved these changes
Jun 3, 2026
MonikaKirkova
added
💥 status: in-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17305
Description
Invokes cdr
markForCheckin the overlay service's opening and closing callbacks after the internal_collapsedmember has been changed.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
IgxDatePicker
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)